Skip to content

Fix vignettes/example-ratio-study.Rmd#22

Merged
wrridgeway merged 3 commits intomasterfrom
21-fix-vignettesexample-ratio-studyrmd
Feb 5, 2026
Merged

Fix vignettes/example-ratio-study.Rmd#22
wrridgeway merged 3 commits intomasterfrom
21-fix-vignettesexample-ratio-studyrmd

Conversation

@wrridgeway
Copy link
Copy Markdown
Member

@wrridgeway wrridgeway commented Feb 5, 2026

Graph resolves itself without the zero $ sales:

Image

@wrridgeway wrridgeway linked an issue Feb 5, 2026 that may be closed by this pull request
3 tasks
# Load 100k rows of 2022 sales data
sales <- read_json(
paste0(
URLencode(paste0(
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately I had to use URLencode() here since sending a > sign really pisses off the socrata API.

@wrridgeway wrridgeway marked this pull request as ready for review February 5, 2026 18:18
@wrridgeway wrridgeway requested a review from a team as a code owner February 5, 2026 18:18
@wrridgeway wrridgeway self-assigned this Feb 5, 2026
@wrridgeway
Copy link
Copy Markdown
Member Author

Rendered vignette.

Copy link
Copy Markdown
Member

@ccao-jardine ccao-jardine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix! I am appeased and I hope pkgdown will be, too.

@wrridgeway wrridgeway merged commit 9d52b19 into master Feb 5, 2026
9 checks passed
@wrridgeway wrridgeway deleted the 21-fix-vignettesexample-ratio-studyrmd branch February 5, 2026 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix vignettes/example-ratio-study.Rmd

2 participants